builder-tool: Fix property check
authorMatthias Clasen <mclasen@redhat.com>
Tue, 23 Apr 2019 21:25:59 +0000 (21:25 +0000)
committerMatthias Clasen <mclasen@redhat.com>
Tue, 23 Apr 2019 21:25:59 +0000 (21:25 +0000)
Embarrassingly, there was a missing else
causing us to check all packing properties
as object properties, never finding them.

gtk/tools/gtk-builder-tool-simplify.c

index 7d64b2aa41168ee5d316986d8c7335848e17a44a..9b7eeeba14ba3ed0c63ab7b824efd83c99f30d3c 100644 (file)
@@ -500,7 +500,7 @@ property_can_be_omitted (Element      *element,
 
   if (g_str_equal (element->parent->element_name, "packing"))
     kind = PROP_KIND_PACKING;
-  if (g_str_equal (element->parent->element_name, "cell-packing"))
+  else if (g_str_equal (element->parent->element_name, "cell-packing"))
     kind = PROP_KIND_CELL_PACKING;
   else
     kind = PROP_KIND_OBJECT;
@@ -522,7 +522,8 @@ property_can_be_omitted (Element      *element,
         property_name = (const gchar *)element->attribute_values[i];
     }
 
-  if (keep_for_rewrite (class_name, property_name, kind))
+  if (data->convert3to4 && 
+      keep_for_rewrite (class_name, property_name, kind))
     return FALSE; /* keep, will be rewritten */
 
   if (translatable)